fix(tree): check for all synonyms of conflicting default args #1547
+46
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
+ Coverage 72.27% 72.30% +0.03%
==========================================
Files 79 79
Lines 8273 8273
Branches 1691 1691
==========================================
+ Hits 5979 5982 +3
+ Misses 2009 2006 -3
Partials 285 285 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Would be nice if someone could look at this, e.g. @huddlej @victorlin @tsibley @genehack @joverlee521 @jameshadfield |
genehack
reviewed
Jul 24, 2024
huddlej
approved these changes
Jul 24, 2024
Contributor
huddlej
left a comment
huddlej
left a comment
There was a problem hiding this comment.
Thanks, @corneliusroemer! Nice to have the check for modern synonyms and also clearer to use those throughout the docs and tests (-czb has always confused me, for example, and --polytomy is much clearer).
IQtree2 has multiple synonyms for default args We were only checking for one of the synonyms. This PR fixes that. It also uses the currently preferred name for all IQtree options, where "preferred" is defined as the name shown in `iqtree2 -h` List of changes: `-nt` -> `-T` `--ntmax` -> `--threads-max` `-czb` -> `--polytomy` List of synonyms: `-ntmax`==`--threads-max` `-s`==`--aln`==`--msa` `-m`==`--model`
^ Conflicts: ^ CHANGES.md
corneliusroemer
force-pushed
the
iqtree-args
branch
from
96b0c04 to
9b9b864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-redoto iqtree argsDescription of proposed changes
See commit messages for details.
Related issue(s)
Inspired by iqtree/iqtree2#273
Checklist